Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incremental requires #19108

Merged
merged 1 commit into from
Oct 26, 2016
Merged

fix incremental requires #19108

merged 1 commit into from
Oct 26, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 25, 2016

prevent read_verify_mod_list from adding a binding to Main

ref #18839 (comment)

@vtjnash vtjnash added compiler:precompilation Precompilation of modules backport pending 0.5 bugfix This change fixes an existing bug labels Oct 25, 2016
@tkelman
Copy link
Contributor

tkelman commented Oct 26, 2016

can this be tested in test/compile?

@tkelman tkelman added the needs tests Unit tests are required for this change label Oct 26, 2016
prevent read_verify_mod_list from adding a binding to Main
@vtjnash vtjnash removed the needs tests Unit tests are required for this change label Oct 26, 2016
@tkelman tkelman merged commit 993c121 into master Oct 26, 2016
@tkelman tkelman deleted the jn/incremental-require branch October 26, 2016 23:31
tkelman pushed a commit that referenced this pull request Feb 22, 2017
prevent read_verify_mod_list from adding a binding to Main
(cherry picked from commit 993c121)
fcard pushed a commit to fcard/julia that referenced this pull request Feb 28, 2017
prevent read_verify_mod_list from adding a binding to Main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:precompilation Precompilation of modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants