Skip to content

Add tests for invalidation fixes #47022

Open

Description

Invalidation fixes to Julia base are currently not tested. For example:

This is asking for double work in the long run. Would it be possible to add something like SnoopCompileCore.@snoopr to Julia base? This would make it easier to add a tests. For example, #46481 fixes invalidations caused by inserting:

Base.:(!)(::True) = False()

With @snoopr defined as

https://github.com/timholy/SnoopCompile.jl/blob/f4d9a7b57a82c1bdb34579f255d3cf4abcc10b92/SnoopCompileCore/src/snoopr.jl#L26-L35

the method insertion could be tested with:

@test isempty(@snoopr Base.:(!)(::True) = False())

cc: @timholy, @ranocha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    compiler:latencyCompiler latencytestThis change adds or pertains to unit tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions