Skip to content

cholfact[!] does not respect the uplo character #22187

Closed

Description

cholfact and cholfact! has an optional uplo input to only consider the upper/lower part of the matrix, but this is not taken into account when checking ishermitian(). For instance:

julia> A = [2. 1.; 0. 2.]
2×2 Array{Float64,2}:
 2.0  1.0
 0.0  2.0

julia> cholfact(A, :U)
ERROR: ArgumentError: matrix is not symmetric/Hermitian. This error can be avoided by calling cholfact(Hermitian(A)) which will ignore either the upper or lower triangle of the matrix.
Stacktrace:
 [1] cholfact(::Array{Float64,2}, ::Symbol) at ./linalg/cholesky.jl:344

This faulty behavior is actually also tested(!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions