Skip to content

Commit fbec395

Browse files
authored
[REPL] Fix a REPL test failure by removing an erroneous space in test (#44972)
* [REPL] remove erroneous space in test Introduced by #33805 (74f2de1). * Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)" This reverts commit 322fd70.
1 parent 190565c commit fbec395

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

stdlib/REPL/test/repl.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ fake_repl(options = REPL.Options(confirm_exit=false,hascolor=true)) do stdin_wri
264264
write(stdin_write, ";")
265265
readuntil(stdout_read, "shell> ")
266266
Base.print_shell_escaped(stdin_write, Base.julia_cmd().exec..., special=Base.shell_special)
267-
write(stdin_write, """ -e "println(\\"HI\\")\" """)
267+
write(stdin_write, """ -e "println(\\"HI\\")\"""")
268268
readuntil(stdout_read, ")\"")
269269
proc_stdout_read, proc_stdout = redirect_stdout()
270270
get_stdout = @async read(proc_stdout_read, String)

test/runtests.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,6 @@ move_to_node1("Distributed")
7878
# Ensure things like consuming all kernel pipe memory doesn't interfere with other tests
7979
move_to_node1("stress")
8080

81-
# TODO: remove `REPL` from the "move to node 1" tests.
82-
# We first need to fix the underlying bugs that are causing the `REPL` tests to frequently
83-
# fail on the `test x86_64-apple-darwin` tester on Buildkite.
84-
move_to_node1("REPL")
85-
8681
# In a constrained memory environment, run the "distributed" test after all other tests
8782
# since it starts a lot of workers and can easily exceed the maximum memory
8883
limited_worker_rss && move_to_node1("Distributed")

0 commit comments

Comments
 (0)