Skip to content

Commit fa24c74

Browse files
dkarraschstaticfloat
authored andcommitted
Fix typo in triangular ldiv! (#43962)
(cherry picked from commit c3235cd)
1 parent e292a89 commit fa24c74

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

stdlib/LinearAlgebra/src/triangular.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1486,7 +1486,7 @@ end
14861486
function ldiv!(xA::Union{UpperTriangular,UnitUpperTriangular}, B::UpperTriangular)
14871487
return UpperTriangular(ldiv!(xA, triu!(B.data)))
14881488
end
1489-
function ldiv!(xA::Union{LowerTriangular,UnitLowerTriangular}, B::UpperTriangular)
1489+
function ldiv!(xA::Union{LowerTriangular,UnitLowerTriangular}, B::LowerTriangular)
14901490
return LowerTriangular(ldiv!(xA, tril!(B.data)))
14911491
end
14921492

stdlib/LinearAlgebra/test/triangular.jl

+2-1
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,8 @@ for elty1 in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFlo
376376
@test_throws DimensionMismatch A2' * offsizeA
377377
@test_throws DimensionMismatch A2 * offsizeA
378378
if (uplo1 == uplo2 && elty1 == elty2 != Int && t1 != UnitLowerTriangular && t1 != UnitUpperTriangular)
379-
@test rdiv!(copy(A1), copy(A2)) A1/A2 Matrix(A1)/Matrix(A2)
379+
@test rdiv!(copy(A1), copy(A2))::t1 A1/A2 Matrix(A1)/Matrix(A2)
380+
@test ldiv!(copy(A2), copy(A1))::t1 A2\A1 Matrix(A2)\Matrix(A1)
380381
end
381382
if (uplo1 != uplo2 && elty1 == elty2 != Int && t2 != UnitLowerTriangular && t2 != UnitUpperTriangular)
382383
@test lmul!(adjoint(copy(A1)), copy(A2)) A1'*A2 Matrix(A1)'*Matrix(A2)

0 commit comments

Comments
 (0)