Code clean and make test work.

Co-Authored-By: Jameson Nash <vtjnash+github@gmail.com>

Author: N5N3

base/abstractarray.jl

@@ -104,8 +104,8 @@ If multiple arguments are passed, equivalent to `has_offset_axes(A) | has_offset
 """
 has_offset_axes(A) = _any_tuple(x->Int(first(x))::Int != 1, false, axes(A)...)
 has_offset_axes(A::AbstractVector) = Int(firstindex(A))::Int != 1 # improve performance of a common case (ranges)
-#Use `_any_tuple` to avoid unneed invoke.
-#TODO: call `any` directly once our compiler is ready.
+# Use `_any_tuple` to avoid unneeded invoke.
+# note: this could call `any` directly if the compiler can infer it
 has_offset_axes(As...) = _any_tuple(has_offset_axes, false, As...)
 has_offset_axes(::Colon) = false
 

test/abstractarray.jl

@@ -1572,12 +1572,12 @@ end
 end
 
 module IRUtils
-    include(normpath(@__DIR__, "./compiler/irutils.jl"))
+    include("compiler/irutils.jl")
 end
 
 @testset "strides for ReshapedArray" begin
     # Type-based contiguous Check
-    a = vec(reinterpret(reshape,Int16,reshape(view(reinterpret(Int32,randn(10)),2:11),5,:)))
+    a = vec(reinterpret(reshape, Int16, reshape(view(reinterpret(Int32, randn(10)), 2:11), 5, :)))
     f(a) = only(strides(a));
     @test IRUtils.fully_eliminated(f, Base.typesof(a)) && f(a) == 1
     # General contiguous check
@@ -1624,14 +1624,14 @@ end
     tb = reinterpret(Float64, view(a, 1:2:10))
     tc = reinterpret(Float64, reshape(view(a, 1:3:10), 2, 2, 1))
     # Issue #44040
-    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(ta,tc))
-    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(tc,tc))
-    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(ta,tc,tb))
+    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(ta, tc))
+    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(tc, tc))
+    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(ta, tc, tb))
     # Ranges && CartesianIndices
-    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(1:10,Base.OneTo(10),1.0:2.0,LinRange(1.0,2.0,2),1:2:10,CartesianIndices((1:2:10,1:2:10))))
+    @test IRUtils.fully_eliminated(Base.require_one_based_indexing, Base.typesof(1:10, Base.OneTo(10), 1.0:2.0, LinRange(1.0, 2.0, 2), 1:2:10, CartesianIndices((1:2:10, 1:2:10))))
     # Remind us to call `any` in `Base.has_offset_axes` once our compiler is ready.
-    @inline _has_offset_axes(A) = @inline any(x->Int(first(x))::Int != 1, axes(A))
+    @inline _has_offset_axes(A) = @inline any(x -> Int(first(x))::Int != 1, axes(A))
     @inline _has_offset_axes(As...) = @inline any(_has_offset_axes, As)
-    a, b = zeros(2,2,2), zeros(2,2)
-    @test_broken IRUtils.fully_eliminated(_has_offset_axes, Base.typesof(a,a,b,b))
+    a, b = zeros(2, 2, 2), zeros(2, 2)
+    @test_broken IRUtils.fully_eliminated(_has_offset_axes, Base.typesof(a, a, b, b))
 end

test/ranges.jl

@@ -2032,9 +2032,11 @@ end
 end
 
 @testset "length(StepRange()) type stability" begin
-    typeof(length(StepRange(1,Int128(1),1))) == typeof(length(StepRange(1,Int128(1),0))) #bigints
-    typeof(length(StepRange(Int8(1),Int128(1),Int8(1)))) == typeof(length(StepRange(Int8(1),Int128(1),Int8(0)))) #smallints
-    typeof(checked_length(StepRange(1,Int128(1),1))) == typeof(checked_length(StepRange(1,Int128(1),0)))
+    for SR in (StepRange{Int,Int128}, StepRange{Int8,Int128})
+        r1, r2 = SR(1, 1, 1), SR(1, 1, 0)
+        @test typeof(length(r1)) == typeof(checked_length(r1)) ==
+              typeof(length(r2)) == typeof(checked_length(r2))
+    end
 end
 
 @testset "LinRange eltype for element types that wrap integers" begin
@@ -2351,10 +2353,8 @@ end
 
 @testset "firstindex(::StepRange{T,T})" begin
     test_firstindex(x) = firstindex(x) === first(Base.axes1(x))
-    for T1 in (Int8,Int16,Int32,Int64,Int128), T2 in (Int8,Int16,Int32,Int64,Int128)
-        for T in (T1, unsigned(T1)), S in (T2, unsigned(T2))
-            @test test_firstindex(StepRange{T,S}(1,1,1))
-            @test test_firstindex(StepRange{T,S}(1,1,0))
-        end
+    for T in Base.BitInteger_types, S in Base.BitInteger_types
+        @test test_firstindex(StepRange{T,S}(1, 1, 1))
+        @test test_firstindex(StepRange{T,S}(1, 1, 0))
     end
 end