suggestions

Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com>

Author: IanButterworth

base/asyncevent.jl

@@ -90,8 +90,8 @@ mutable struct Timer
     cond::ThreadSynchronizer
     @atomic isopen::Bool
     @atomic set::Bool
-    timeout::Real
-    interval::Real
+    timeout_ms::UInt64
+    interval_ms::UInt64
 
     function Timer(timeout::Real; interval::Real = 0.0)
         timeout ≥ 0 || throw(ArgumentError("timer cannot have negative timeout of $timeout seconds"))
@@ -101,7 +101,7 @@ mutable struct Timer
         intervalms = ceil(UInt64, interval * 1000)
         loop = eventloop()
 
-        this = new(Libc.malloc(_sizeof_uv_timer), ThreadSynchronizer(), true, false, timeout, interval)
+        this = new(Libc.malloc(_sizeof_uv_timer), ThreadSynchronizer(), true, false, timeoutms, intervalms)
         associate_julia_struct(this.handle, this)
         iolock_begin()
         err = ccall(:uv_timer_init, Cint, (Ptr{Cvoid}, Ptr{Cvoid}), loop, this)
@@ -116,10 +116,26 @@ mutable struct Timer
         return this
     end
 end
+function getproperty(t::Timer, f::Symbol)
+    if f == :timeout
+        if t.timeout_ms == 0
+            return t.timeout_ms / 1000
+        else # undo the +1ms from the constructor
+            return (t.timeout_ms - 1) / 1000
+        end
+    elseif f == :interval
+        return t.interval_ms / 1000
+    else
+        return getfield(t, f)
+    end
+end
+propertynames(::Type{Timer}) = (:handle, :cond, :isopen, :set, :timeout_ms, :timeout, :interval_ms, :interval)
 
 function show(io::IO, t::Timer)
     state = isopen(t) ? "open" : "closed"
-    print(io, "Timer ($state, timeout: $(t.timeout), interval: $(t.interval)) @0x$(string(convert(UInt, pointer_from_objref(t)), base = 16, pad = Sys.WORD_SIZE>>2))")
+    interval = t.interval
+    interval_str = interval > 0 ? ", interval: $(t.interval) s" : ""
+    print(io, "Timer ($state, timeout: $(t.timeout) s$interval_str) @0x$(string(convert(UInt, pointer_from_objref(t)), base = 16, pad = Sys.WORD_SIZE>>2))")
 end
 
 unsafe_convert(::Type{Ptr{Cvoid}}, t::Timer) = t.handle