Skip to content

Commit e0b9b80

Browse files
committed
Remove all mentions of USE_SYSTEM_LIBM
1 parent dd56051 commit e0b9b80

File tree

6 files changed

+5
-76
lines changed

6 files changed

+5
-76
lines changed

Make.inc

+5-19
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ USE_SYSTEM_LLVM:=0
3737
USE_SYSTEM_LIBUNWIND:=0
3838
DISABLE_LIBUNWIND:=0
3939
USE_SYSTEM_PCRE:=0
40-
#USE_SYSTEM_LIBM:=0
41-
USE_SYSTEM_LIBM:=1
42-
USE_SYSTEM_OPENLIBM:=0
4340
UNTRUSTED_SYSTEM_LIBM:=0
4441
USE_SYSTEM_DSFMT:=0
4542
USE_SYSTEM_BLAS:=0
@@ -1123,11 +1120,6 @@ LIBLAPACKNAME := liblapack
11231120
endif
11241121
endif
11251122

1126-
ifeq ($(USE_SYSTEM_LIBM), 1)
1127-
LIBM := -lm
1128-
LIBMNAME := libm
1129-
endif
1130-
11311123
ifeq ($(USE_SYSTEM_LIBUV), 1)
11321124
LIBUV := $(LOCALBASE)/lib/libuv-julia.a
11331125
LIBUV_INC := $(LOCALBASE)/include
@@ -1185,7 +1177,7 @@ LIBGFORTRAN_VERSION := $(subst libgfortran,,$(filter libgfortran%,$(subst -,$(SP
11851177
# Note: we explicitly _do not_ define `CSL` here, since it requires some more
11861178
# advanced techniques to decide whether it should be installed from a BB source
11871179
# or not. See `deps/csl.mk` for more detail.
1188-
BB_PROJECTS := BLASTRAMPOLINE OPENBLAS LLVM LIBSUITESPARSE OPENLIBM GMP MBEDTLS LIBSSH2 NGHTTP2 MPFR CURL LIBGIT2 PCRE LIBUV LIBUNWIND DSFMT OBJCONV ZLIB P7ZIP
1180+
BB_PROJECTS := BLASTRAMPOLINE OPENBLAS LLVM LIBSUITESPARSE GMP MBEDTLS LIBSSH2 NGHTTP2 MPFR CURL LIBGIT2 PCRE LIBUV LIBUNWIND DSFMT OBJCONV ZLIB P7ZIP
11891181
define SET_BB_DEFAULT
11901182
# First, check to see if BB is disabled on a global setting
11911183
ifeq ($$(USE_BINARYBUILDER),0)
@@ -1396,12 +1388,6 @@ USE_BINARYBUILDER_OPENBLAS := 0
13961388
USE_BINARYBUILDER_LIBSUITESPARSE := 0
13971389
endif
13981390

1399-
ifeq ($(USE_SYSTEM_LIBM),1)
1400-
# If we're using system libm, disable BB OpenLibm
1401-
USE_BINARYBUILDER_OPENLIBM := 0
1402-
endif
1403-
1404-
14051391
# Note: we're passing *FLAGS here computed based on your system compiler to
14061392
# clang. If that causes you problems, you might want to build and/or run
14071393
# specific clang-sa-* files with clang explicitly selected:
@@ -1543,10 +1529,10 @@ LIBGCC_INSTALL_DEPLIB := $(call dep_lib_path,$(libdir),$(private_shlibdir)/$(LIB
15431529
# That second point will no longer be true for most deps once they are placed within Artifacts directories.
15441530
# Note that we prefix `libjulia-codegen` and `libjulia-internal` with `@` to signify to the loader that it
15451531
# should not automatically dlopen() it in its loading loop.
1546-
LOADER_BUILD_DEP_LIBS = $(LIBGCC_BUILD_DEPLIB):$(LIBM_BUILD_DEPLIB):@$(LIBJULIAINTERNAL_BUILD_DEPLIB):@$(LIBJULIACODEGEN_BUILD_DEPLIB):
1547-
LOADER_DEBUG_BUILD_DEP_LIBS = $(LIBGCC_BUILD_DEPLIB):$(LIBM_BUILD_DEPLIB):@$(LIBJULIAINTERNAL_DEBUG_BUILD_DEPLIB):@$(LIBJULIACODEGEN_DEBUG_BUILD_DEPLIB):
1548-
LOADER_INSTALL_DEP_LIBS = $(LIBGCC_INSTALL_DEPLIB):$(LIBM_INSTALL_DEPLIB):@$(LIBJULIAINTERNAL_INSTALL_DEPLIB):@$(LIBJULIACODEGEN_INSTALL_DEPLIB):
1549-
LOADER_DEBUG_INSTALL_DEP_LIBS = $(LIBGCC_INSTALL_DEPLIB):$(LIBM_INSTALL_DEPLIB):@$(LIBJULIAINTERNAL_DEBUG_INSTALL_DEPLIB):@$(LIBJULIACODEGEN_DEBUG_INSTALL_DEPLIB):
1532+
LOADER_BUILD_DEP_LIBS = $(LIBGCC_BUILD_DEPLIB):@$(LIBJULIAINTERNAL_BUILD_DEPLIB):@$(LIBJULIACODEGEN_BUILD_DEPLIB):
1533+
LOADER_DEBUG_BUILD_DEP_LIBS = $(LIBGCC_BUILD_DEPLIB):@$(LIBJULIAINTERNAL_DEBUG_BUILD_DEPLIB):@$(LIBJULIACODEGEN_DEBUG_BUILD_DEPLIB):
1534+
LOADER_INSTALL_DEP_LIBS = $(LIBGCC_INSTALL_DEPLIB):@$(LIBJULIAINTERNAL_INSTALL_DEPLIB):@$(LIBJULIACODEGEN_INSTALL_DEPLIB):
1535+
LOADER_DEBUG_INSTALL_DEP_LIBS = $(LIBGCC_INSTALL_DEPLIB):@$(LIBJULIAINTERNAL_DEBUG_INSTALL_DEPLIB):@$(LIBJULIACODEGEN_DEBUG_INSTALL_DEPLIB):
15501536

15511537
# Colors for make
15521538
ifndef VERBOSE

Makefile

-8
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,6 @@ JL_PRIVATE_LIBS-$(USE_SYSTEM_LLVM) += libLLVM libLLVM-12jl
192192
endif
193193
JL_PRIVATE_LIBS-$(USE_SYSTEM_LIBUNWIND) += libunwind
194194

195-
ifeq ($(USE_SYSTEM_LIBM),0)
196-
JL_PRIVATE_LIBS-$(USE_SYSTEM_OPENLIBM) += libopenlibm
197-
endif
198-
199195
JL_PRIVATE_LIBS-$(USE_SYSTEM_BLAS) += $(LIBBLASNAME)
200196
ifneq ($(LIBLAPACKNAME),$(LIBBLASNAME))
201197
JL_PRIVATE_LIBS-$(USE_SYSTEM_LAPACK) += $(LIBLAPACKNAME)
@@ -249,10 +245,6 @@ ifeq ($(BUNDLE_DEBUG_LIBS),1)
249245
-$(INSTALL_M) $(build_bindir)/libjulia-debug.dll $(DESTDIR)$(bindir)/
250246
-$(INSTALL_M) $(build_libdir)/libjulia-debug.dll.a $(DESTDIR)$(libdir)/
251247
endif
252-
ifeq ($(USE_SYSTEM_LIBM),0)
253-
-$(INSTALL_M) $(build_bindir)/libopenlibm.dll.a $(DESTDIR)$(libdir)/
254-
endif
255-
else
256248

257249
# Copy over .dSYM directories directly for Darwin
258250
ifneq ($(DARWIN_FRAMEWORK),1)

base/Makefile

-7
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ ifeq ($(XC_HOST),)
4646
else
4747
@echo "const MACHINE = \"$(XC_HOST)\"" >> $@
4848
endif
49-
@echo "const libm_name = \"$(LIBMNAME)\"" >> $@
5049
@echo "const libblas_name = \"$(LIBBLASNAME)\"" >> $@
5150
@echo "const liblapack_name = \"$(LIBLAPACKNAME)\"" >> $@
5251
ifeq ($(USE_BLAS64), 1)
@@ -187,12 +186,6 @@ endef
187186

188187
# the following excludes: libuv.a, libutf8proc.a
189188

190-
#ifneq ($(USE_SYSTEM_LIBM),0)
191-
#$(eval $(call symlink_system_library,LIBM,$(LIBMNAME)))
192-
#else ifneq ($(USE_SYSTEM_OPENLIBM),0)
193-
#$(eval $(call symlink_system_library,OPENLIBM,$(LIBMNAME)))
194-
#endif
195-
196189
$(eval $(call symlink_system_library,CSL,libgcc_s,1))
197190
ifneq (,$(LIBGFORTRAN_VERSION))
198191
$(eval $(call symlink_system_library,CSL,libgfortran,$(LIBGFORTRAN_VERSION)))

deps/Makefile

-6
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,6 @@ PATCHELF_BIN := $(CUSTOM_LD_LIBRARY_PATH) $(PATCHELF)
7474

7575
## USE_SYSTEM_LIBS options
7676

77-
ifeq ($(USE_SYSTEM_OPENLIBM), 0)
78-
ifeq ($(USE_SYSTEM_LIBM), 0)
79-
DEP_LIBS += openlibm
80-
endif
81-
endif
82-
8377
ifeq ($(USE_SYSTEM_DSFMT), 0)
8478
DEP_LIBS += dsfmt
8579
endif

deps/openlibm.mk

-34
This file was deleted.

deps/openlibm.version

-2
This file was deleted.

0 commit comments

Comments
 (0)