From d605eea27f6ffefe21258aaa33cc03cbf42880d7 Mon Sep 17 00:00:00 2001 From: Andreas Noack Date: Thu, 29 Jun 2017 15:41:36 -0400 Subject: [PATCH] Add NEWS.md entry --- NEWS.md | 3 +++ base/linalg/bunchkaufman.jl | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 514a7b82d3fa8..bcc6987ab6606 100644 --- a/NEWS.md +++ b/NEWS.md @@ -105,6 +105,9 @@ Deprecated or removed have been deprecated in favor of `isposdef(Hermitian(A, UL))` and `isposdef!(Hermitian(A, UL))` respectively ([#22245]). + * The `bkfact`/`bkfact!` methods that accepted `uplo` and `issymmetric` symbols have been deprecated + in favor of using `Hermitian` (or `Symmetric`) views ([#22605]). + * The function `current_module` is deprecated and replaced with `@__MODULE__` ([#22064]). This caused the deprecation of some reflection methods (such as `macroexpand` and `isconst`), which now require a module argument. diff --git a/base/linalg/bunchkaufman.jl b/base/linalg/bunchkaufman.jl index a10739a8a4f4c..7f753306f3b7d 100644 --- a/base/linalg/bunchkaufman.jl +++ b/base/linalg/bunchkaufman.jl @@ -22,7 +22,7 @@ BunchKaufman(A::AbstractMatrix{T}, ipiv::Vector{BlasInt}, uplo::Char, symmetric: `bkfact!` is the same as [`bkfact`](@ref), but saves space by overwriting the input `A`, instead of creating a copy. """ -function bkfact!(A::RealHermSymComplexSym{T,S} where {T<:BlasFloat,S<:StridedMatrix{T}}, rook::Bool = false) +function bkfact!(A::RealHermSymComplexSym{T,S} where {T<:BlasReal,S<:StridedMatrix}, rook::Bool = false) LD, ipiv, info = rook ? LAPACK.sytrf_rook!(A.uplo, A.data) : LAPACK.sytrf!(A.uplo, A.data) BunchKaufman(LD, ipiv, A.uplo, true, rook, info) end