Don't prompt field names for tuples at the REPL (#46897)

JuliaLang · Sep 25, 2022 · d5cde86 · d5cde86 · nanosoldier · Sep 25, 2022
1 parent e6d9979
commit d5cde86
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/stdlib/REPL/src/REPLCompletions.jl b/stdlib/REPL/src/REPLCompletions.jl
@@ -202,7 +202,7 @@ function complete_symbol(sym::String, @nospecialize(ffunc), context_module::Modu
                 t = typeof(t.parameters[1])
             end
             # Only look for fields if this is a concrete type
-            if isconcretetype(t)
+            if isconcretetype(t) && !(t <: Tuple)
                 fields = fieldnames(t)
                 for field in fields
                     s = string(field)

diff --git a/stdlib/REPL/test/replcompletions.jl b/stdlib/REPL/test/replcompletions.jl
@@ -293,6 +293,12 @@ let
     @test isempty(c)
 end
 
+# issue 46800: (3,2).<TAB> errors in the REPL
+let
+    c, r = test_complete("(3,2).")
+    @test isempty(c)
+end
+
 # inexistent completion inside a string
 @test_nocompletion("Base.print(\"lol")