fixup! [Make] remove BINARYBUILDER_LLVM_ASSERTS and use LLVM_ASSERTIONS instead

This got corrupted in 7c0cb30,
though we can also update to be a bit more explicit about our cantFail
expectations and often avoid the issue.

Author: vtjnash

Make.inc

@@ -450,10 +450,6 @@ CXX_DISABLE_ASSERTION := -DJL_NDEBUG
 DISABLE_ASSERTIONS := -DNDEBUG -DJL_NDEBUG
 endif
 
-ifeq ($(LLVM_ASSERTIONS),0)
-CXX_DISABLE_ASSERTION += -DNDEBUG
-endif
-
 # Compiler specific stuff
 
 ifeq ($(USEMSVC), 1)

src/debuginfo.cpp

@@ -973,10 +973,10 @@ static objfileentry_t &find_object_file(uint64_t fbase, StringRef fname) JL_NOTS
                     DebugInfo(errorCodeToError(std::make_error_code(std::errc::no_such_file_or_directory)));
                 // Can't find a way to construct an empty Expected object
                 // that can be ignored.
-                ignoreError(DebugInfo);
                 if (fname.substr(sep + 1) != info.filename) {
                     debuginfopath = fname.substr(0, sep + 1).str();
                     debuginfopath += info.filename;
+                    ignoreError(DebugInfo);
                     DebugInfo = openDebugInfo(debuginfopath, info);
                 }
                 if (!DebugInfo) {
@@ -994,9 +994,8 @@ static objfileentry_t &find_object_file(uint64_t fbase, StringRef fname) JL_NOTS
                     DebugInfo = openDebugInfo(debuginfopath, info);
                 }
                 if (DebugInfo) {
-                    errorobj = std::move(DebugInfo);
+                    errorobj = cantFail(std::move(DebugInfo));
                     // Yes, we've checked, and yes LLVM want us to check again.
-                    assert(errorobj);
                     debugobj = errorobj->getBinary();
                 }
                 else {

src/jitlayers.cpp

@@ -488,9 +488,7 @@ void JuliaOJIT::DebugObjectRegistrar::registerObject(RTDyldObjHandleT H, const O
             continue;
         if (!(Flags & object::BasicSymbolRef::SF_Exported))
             continue;
-        auto NameOrError = Symbol.getName();
-        assert(NameOrError);
-        auto Name = NameOrError.get();
+        auto Name = cantFail(Symbol.getName());
         auto Sym = JIT.CompileLayer.findSymbolIn(H, Name.str(), true);
         assert(Sym);
         // note: calling getAddress here eagerly finalizes H