wip: add target test cases

Author: aviatesk

test/compiler/inline.jl

@@ -1361,6 +1361,14 @@ mutable struct DoAllocWithField
         end
     end
 end
+mutable struct DoAllocWithFieldInter
+    x::Int
+end
+function register_finalizer!(obj::DoAllocWithFieldInter)
+    finalizer(obj) do this
+        add_finalization_count!(this.x)
+    end
+end
 
 function const_finalization(io)
     for i = 1:1000
@@ -1378,86 +1386,98 @@ let
 end
 
 # tests finalizer inlining when def/uses involve control flow
-Base.@assume_effects :nothrow safeprint(@nospecialize x...) = print(x...)
-mutable struct DoAllocWithField
-    x
-    function DoAllocWithField(x)
-        finalizer(new(x)) do this
-            nothrow_side_effect(nothing)
+function cfg_finalization1(io)
+    for i = -999:1000
+        o = DoAllocWithField(i)
+        if i == 1000
+            safeprint(io, o.x, '\n')
+        elseif i > 0
+            safeprint(io, o.x)
         end
     end
 end
-mutable struct DoAllocWithFieldInter
-    x
+let src = code_typed1(cfg_finalization1, (IO,))
+    @test count(isinvoke(:add_finalization_count!), src.code) == 1
 end
-function register_finalizer!(obj::DoAllocWithFieldInter)
-    finalizer(obj) do this
-        nothrow_side_effect(nothing)
-    end
+let
+    init_finalization_count!()
+    cfg_finalization1(IOBuffer())
+    @test get_finalization_count() == 1000
 end
-let src = code_typed1() do
-        for i = -1000:1000
-            o = DoAllocWithField(i)
-            if i == 1000
-                safeprint(o.x, '\n')
-            elseif i > 0
-                safeprint(o.x)
-            end
+
+function cfg_finalization2(io)
+    for i = -999:1000
+        o = DoAllocWithField(0)
+        o.x = i # with `setfield!`
+        if i == 1000
+            safeprint(io, o.x, '\n')
+        elseif i > 0
+            safeprint(io, o.x)
         end
     end
-    @test count(isinvoke(:nothrow_side_effect), src.code) == 1
 end
-let src = code_typed1() do
-        for i = -1000:1000
-            o = DoAllocWithField(0)
-            o.x = i # with `setfield!`
-            if i == 1000
-                safeprint(o.x, '\n')
-            elseif i > 0
-                safeprint(o.x)
-            end
-        end
-    end
-    @test count(isinvoke(:nothrow_side_effect), src.code) == 1
+let src = code_typed1(cfg_finalization2, (IO,))
+    @test count(isinvoke(:add_finalization_count!), src.code) == 1
 end
-let src = code_typed1() do
-        for i = -1000:1000
-            o = DoAllocWithFieldInter(i)
-            register_finalizer!(o)
-            if i == 1000
-                safeprint(o.x, '\n')
-            elseif i > 0
-                safeprint(o.x)
-            end
+let
+    init_finalization_count!()
+    cfg_finalization2(IOBuffer())
+    @test get_finalization_count() == 1000
+end
+
+function cfg_finalization3(io)
+    for i = -999:1000
+        o = DoAllocWithFieldInter(i)
+        register_finalizer!(o)
+        if i == 1000
+            safeprint(io, o.x, '\n')
+        elseif i > 0
+            safeprint(io, o.x)
         end
     end
-    @test count(isinvoke(:nothrow_side_effect), src.code) == 1
 end
-let src = code_typed1() do
-        for i = -1000:1000
-            o = DoAllocWithFieldInter(0)
-            o.x = i # with `setfield!``
-            register_finalizer!(o)
-            if i == 1000
-                safeprint(o.x, '\n')
-            elseif i > 0
-                safeprint(o.x)
-            end
+let src = code_typed1(cfg_finalization3, (IO,))
+    @test count(isinvoke(:add_finalization_count!), src.code) == 1
+end
+let
+    init_finalization_count!()
+    cfg_finalization3(IOBuffer())
+    @test get_finalization_count() == 1000
+end
+
+function cfg_finalization4(io)
+    for i = -999:1000
+        o = DoAllocWithFieldInter(0)
+        o.x = i # with `setfield!`
+        register_finalizer!(o)
+        if i == 1000
+            safeprint(io, o.x, '\n')
+        elseif i > 0
+            safeprint(io, o.x)
         end
     end
-    @test count(isinvoke(:nothrow_side_effect), src.code) == 1
 end
-let src = code_typed1() do
-        for i = -1000:1000
-            o = DoAllocWithFieldInter(i)
-            if i == 1000
-                safeprint(o.x, '\n')
-            elseif i > 0
-                safeprint(o.x)
-            end
-            register_finalizer!(o)
+let src = code_typed1(cfg_finalization4, (IO,))
+    @test count(isinvoke(:add_finalization_count!), src.code) == 1
+end
+let
+    init_finalization_count!()
+    cfg_finalization4(IOBuffer())
+    @test get_finalization_count() == 1000
+end
+
+function cfg_finalization5(io)
+    for i = -999:1000
+        o = DoAllocWithFieldInter(i)
+        if i == 1000
+            safeprint(io, o.x, '\n')
+        elseif i > 0
+            safeprint(io, o.x)
         end
+        register_finalizer!(o)
     end
+end
+let src = code_typed1(cfg_finalization5, (IO,))
     # TODO we can fix this case by checking a case when a finalizer block is post-dominated by all the def/uses
     @test_broken count(isinvoke(:nothrow_side_effect), src.code) == 1
 end