Fix segfault in Diagonal * OffsetMatrix (#45548)

* diagonal*offset matrix should throw

(cherry picked from commit 172bddc)

Author: jishnub

stdlib/LinearAlgebra/src/diagonal.jl

@@ -285,6 +285,7 @@ function *(D::Diagonal, transA::Transpose{<:Any,<:AbstractMatrix})
 end
 
 @inline function __muldiag!(out, D::Diagonal, B, alpha, beta)
+    require_one_based_indexing(B)
     require_one_based_indexing(out)
     if iszero(alpha)
         _rmul_or_fill!(out, beta)
@@ -306,6 +307,7 @@ end
     return out
 end
 @inline function __muldiag!(out, A, D::Diagonal, alpha, beta)
+    require_one_based_indexing(A)
     require_one_based_indexing(out)
     if iszero(alpha)
         _rmul_or_fill!(out, beta)

stdlib/LinearAlgebra/test/diagonal.jl

@@ -9,6 +9,9 @@ const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test")
 isdefined(Main, :Furlongs) || @eval Main include(joinpath($(BASE_TEST_PATH), "testhelpers", "Furlongs.jl"))
 using .Main.Furlongs
 
+isdefined(Main, :OffsetArrays) || @eval Main include(joinpath($(BASE_TEST_PATH), "testhelpers", "OffsetArrays.jl"))
+using .Main.OffsetArrays
+
 n=12 #Size of matrix problem to test
 Random.seed!(1)
 
@@ -785,6 +788,16 @@ end
     @test_throws DimensionMismatch lmul!(Diagonal([1]), [1,2,3]) # nearby
 end
 
+@testset "Multiplication of a Diagonal with an OffsetArray" begin
+    # Offset indices should throw
+    D = Diagonal(1:4)
+    A = OffsetArray(rand(4,4), 2, 2)
+    @test_throws ArgumentError D * A
+    @test_throws ArgumentError A * D
+    @test_throws ArgumentError mul!(similar(A, size(A)), A, D)
+    @test_throws ArgumentError mul!(similar(A, size(A)), D, A)
+end
+
 @testset "Triangular division by Diagonal #27989" begin
     K = 5
     for elty in (Float32, Float64, ComplexF32, ComplexF64)