Address review comments

JuliaLang · Dec 14, 2022 · 90ea0b5 · 90ea0b5
1 parent 214b39d
commit 90ea0b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/base/Base.jl b/base/Base.jl
@@ -168,7 +168,7 @@ include("idset.jl")
 include("iterators.jl")
 using .Iterators: zip, enumerate, only
 using .Iterators: Flatten, Filter, product  # for generators
-using .Iterators: Stateful    # compat (was formerly used in reinterpretarrays.jl)
+using .Iterators: Stateful    # compat (was formerly used in reinterpretarray.jl)
 
 include("namedtuple.jl")
 

diff --git a/base/array.jl b/base/array.jl
@@ -2731,6 +2731,7 @@ keepat!(a::Vector, m::AbstractVector{Bool}) = _keepat!(a, m)
 # These are moderately efficient, preserve order, and remove dupes.
 
 _unique_filter!(pred::P, update!::U, state) where {P,U} = function (x)
+    # P, U force specialization
     if pred(x, state)
         update!(state, x)
         true

diff --git a/base/logging.jl b/base/logging.jl
@@ -378,7 +378,7 @@ function logmsg_code(_module, file, line, level, message, exs...)
                     id = $(log_data._id)
                     # Second chance at an early bail-out (before computing the message),
                     # based on arbitrary logger-specific logic.
-                    if _invoked_shouldlog(logger, level, _module, group, id)
+                    if invokelatest(shouldlog, logger, level, _module, group, id)
                         file = $(log_data._file)
                         if file isa String
                             file = Base.fixup_stdlib_path(file)