Skip to content

Commit 8aa57a2

Browse files
authored
Fix missing GC root (#59785)
Per #59766 (comment)
1 parent 755bf41 commit 8aa57a2

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/julia.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2016,7 +2016,7 @@ JL_DLLEXPORT jl_value_t *jl_get_module_binding_or_nothing(jl_module_t *m, jl_sym
20162016

20172017
// get binding for reading
20182018
JL_DLLEXPORT jl_binding_t *jl_get_binding(jl_module_t *m JL_PROPAGATES_ROOT, jl_sym_t *var);
2019-
JL_DLLEXPORT jl_value_t *jl_module_globalref(jl_module_t *m, jl_sym_t *var) JL_GLOBALLY_ROOTED;
2019+
JL_DLLEXPORT jl_value_t *jl_module_globalref(jl_module_t *m JL_PROPAGATES_ROOT, jl_sym_t *var);
20202020
JL_DLLEXPORT jl_value_t *jl_get_binding_type(jl_module_t *m, jl_sym_t *var);
20212021
// get binding for assignment
20222022
JL_DLLEXPORT void jl_check_binding_currently_writable(jl_binding_t *b, jl_module_t *m, jl_sym_t *s);

src/rtutils.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ JL_DLLEXPORT void JL_NORETURN jl_type_error_global(const char *fname, jl_module_
126126
jl_value_t *got JL_MAYBE_UNROOTED)
127127
{
128128
jl_value_t *gr = jl_module_globalref(mod, sym);
129+
JL_GC_PUSH2(&expected, &got);
129130
jl_value_t *ex = jl_new_struct(jl_typeerror_type, jl_symbol(fname), gr, expected, got);
130131
jl_throw(ex);
131132
}

0 commit comments

Comments
 (0)