Skip to content

Commit 67f1a47

Browse files
giordanostevengj
authored andcommitted
Make inv(::Complex) return zero when input has Inf magnitude (#32050)
1 parent 0bc7bb6 commit 67f1a47

File tree

2 files changed

+47
-2
lines changed

2 files changed

+47
-2
lines changed

base/complex.jl

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,11 @@ julia> conj(1 + 3im)
259259
conj(z::Complex) = Complex(real(z),-imag(z))
260260
abs(z::Complex) = hypot(real(z), imag(z))
261261
abs2(z::Complex) = real(z)*real(z) + imag(z)*imag(z)
262-
inv(z::Complex) = conj(z)/abs2(z)
262+
function inv(z::Complex)
263+
c, d = reim(z)
264+
(isinf(c) | isinf(d)) && return complex(copysign(zero(c), c), flipsign(-zero(d), d))
265+
complex(c, -d)/(c * c + d * d)
266+
end
263267
inv(z::Complex{<:Integer}) = inv(float(z))
264268

265269
+(z::Complex) = Complex(+real(z), +imag(z))
@@ -346,7 +350,7 @@ function /(a::Complex{T}, b::Complex{T}) where T<:Real
346350
end
347351

348352
inv(z::Complex{<:Union{Float16,Float32}}) =
349-
oftype(z, conj(widen(z))/abs2(widen(z)))
353+
oftype(z, inv(widen(z)))
350354

351355
/(z::Complex{T}, w::Complex{T}) where {T<:Union{Float16,Float32}} =
352356
oftype(z, widen(z)*inv(widen(w)))
@@ -430,6 +434,7 @@ end
430434

431435
function inv(w::ComplexF64)
432436
c, d = reim(w)
437+
(isinf(c) | isinf(d)) && return complex(copysign(0.0, c), flipsign(-0.0, d))
433438
half = 0.5
434439
two = 2.0
435440
cd = max(abs(c), abs(d))

test/complex.jl

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -999,6 +999,46 @@ end
999999
end
10001000
end
10011001

1002+
@testset "division by Inf, issue#23134" begin
1003+
@testset "$T" for T in (Float32, Float64, BigFloat)
1004+
@test isequal(one(T) / complex(T(Inf)), complex(zero(T), -zero(T)))
1005+
@test isequal(one(T) / complex(T(Inf), one(T)), complex(zero(T), -zero(T)))
1006+
@test isequal(one(T) / complex(T(Inf), T(NaN)), complex(zero(T), -zero(T)))
1007+
@test isequal(one(T) / complex(T(Inf), T(Inf)), complex(zero(T), -zero(T)))
1008+
1009+
@test isequal(one(T) / complex(T(-Inf)), complex(-zero(T), -zero(T)))
1010+
@test isequal(one(T) / complex(T(-Inf), one(T)), complex(-zero(T), -zero(T)))
1011+
@test isequal(one(T) / complex(T(-Inf), T(NaN)), complex(-zero(T), -zero(T)))
1012+
@test isequal(one(T) / complex(T(-Inf), T(Inf)), complex(-zero(T), -zero(T)))
1013+
1014+
@test isequal(one(T) / complex(T(Inf),-zero(T)), complex(zero(T), zero(T)))
1015+
@test isequal(one(T) / complex(T(Inf),-one(T)), complex(zero(T), zero(T)))
1016+
@test isequal(one(T) / complex(T(Inf),T(-NaN)), complex(zero(T), zero(T)))
1017+
@test isequal(one(T) / complex(T(Inf),T(-Inf)), complex(zero(T), zero(T)))
1018+
1019+
@test isequal(one(T) / complex(T(-Inf),-zero(T)),complex(-zero(T), zero(T)))
1020+
@test isequal(one(T) / complex(T(-Inf),-one(T)), complex(-zero(T), zero(T)))
1021+
@test isequal(one(T) / complex(T(-Inf),T(-NaN)), complex(-zero(T), zero(T)))
1022+
@test isequal(one(T) / complex(T(-Inf),T(-Inf)), complex(-zero(T), zero(T)))
1023+
1024+
@test isequal(one(T) / complex(zero(T), T(Inf)), complex(zero(T), -zero(T)))
1025+
@test isequal(one(T) / complex(one(T), T(Inf)), complex(zero(T), -zero(T)))
1026+
@test isequal(one(T) / complex(T(NaN), T(Inf)), complex(zero(T), -zero(T)))
1027+
1028+
@test isequal(one(T) / complex(zero(T), T(-Inf)), complex(zero(T), zero(T)))
1029+
@test isequal(one(T) / complex(one(T), T(-Inf)), complex(zero(T), zero(T)))
1030+
@test isequal(one(T) / complex(T(NaN), T(-Inf)), complex(zero(T), zero(T)))
1031+
1032+
@test isequal(one(T) / complex(-zero(T), T(Inf)), complex(-zero(T), -zero(T)))
1033+
@test isequal(one(T) / complex(-one(T), T(Inf)), complex(-zero(T), -zero(T)))
1034+
@test isequal(one(T) / complex(T(-NaN), T(Inf)), complex(-zero(T), -zero(T)))
1035+
1036+
@test isequal(one(T) / complex(-zero(T), T(-Inf)), complex(-zero(T), zero(T)))
1037+
@test isequal(one(T) / complex(-one(T), T(-Inf)), complex(-zero(T), zero(T)))
1038+
@test isequal(one(T) / complex(T(-NaN), T(-Inf)), complex(-zero(T), zero(T)))
1039+
end
1040+
end
1041+
10021042
@testset "complex^real, issue #14342" begin
10031043
for T in (Float32, Float64, BigFloat), p in (T(-21//10), -21//10)
10041044
z = T(2)+0im

0 commit comments

Comments
 (0)