Fix ⊊, ⊋ on non-Set arguments (#42155)

JuliaLang · Sep 9, 2021 · 655a1a4 · 655a1a4
1 parent 819c45b
commit 655a1a4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/base/abstractset.jl b/base/abstractset.jl
@@ -338,8 +338,8 @@ false
 """
 ⊊, ⊋
 
-⊊(a::AbstractSet, b) = length(a) < length(b) && a ⊆ b
-⊊(a, b) = Set(a) ⊊ b
+⊊(a::AbstractSet, b::AbstractSet) = length(a) < length(b) && a ⊆ b
+⊊(a, b) = Set(a) ⊊ Set(b)
 ⊋(a, b) = b ⊊ a
 
 function ⊈ end

diff --git a/test/sets.jl b/test/sets.jl
@@ -803,3 +803,8 @@ end
     A = empty!(A)
     @test isempty(A)
 end
+
+@testset "⊊, ⊋" begin
+    @test !((1, 2) ⊊ (1, 2, 2))
+    @test !((1, 2, 2) ⊋ (1, 2))
+end