Skip to content

Commit 5034aab

Browse files
committed
Don't create a subprocess in the REPL precompile script
We use raw Base.Filesystem.File IO on PTYs in the REPL precompile script. Due to #24440, spawning a subprocess using the REPL's shell mode clears the O_NONBLOCK flag set on the PTY, resulting in deadlocks when libuv later reads or writes to it from Julia code. I haven't identified what caused this to become more of a problem recently, but I don't think some extra compilation latency when starting shell mode is worth it if it's causing mystery timeouts in CI.
1 parent d162445 commit 5034aab

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

stdlib/REPL/src/precompile.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ function repl_workload()
6464
display("a string")
6565
foo(x) = 1
6666
@time @eval foo(1)
67-
; pwd
6867
$CTRL_C
6968
$CTRL_R$CTRL_C#
7069
? reinterpret

0 commit comments

Comments
 (0)