Add right arrow and end as completion keys

Author: Octogonapus

stdlib/REPL/src/LineEdit.jl

@@ -2494,7 +2494,9 @@ function bracketed_paste(s::MIState; tabwidth::Int=options(s).tabwidth)
     return replace(input, '\t' => " "^tabwidth)
 end
 
-function tab_should_complete(s::MIState)
+# `key` can either be the tab-completer key if that is a valid textual key or `nothing`
+# if the completer key can't be entered into text.
+function key_should_complete(s::MIState, key::Union{Char,Nothing})
     # Yes, we are ignoring the possibility
     # the we could be in the middle of a multi-byte
     # sequence, here but that's ok, since any
@@ -2503,7 +2505,8 @@ function tab_should_complete(s::MIState)
     pos = position(buf)
     pos == 0 && return true
     c = buf.data[pos]
-    return c != _newline && c != UInt8('\t') &&
+    not_completer_key = key === nothing ? true : c != UInt8(key)
+    return c != _newline && not_completer_key &&
         # hack to allow path completion in cmds
         # after a space, e.g., `cd <tab>`, while still
         # allowing multiple indent levels
@@ -2513,7 +2516,6 @@ end
 # jump_spaces: if cursor is on a ' ', move it to the first non-' ' char on the right
 # if `delete_trailing`, ignore trailing ' ' by deleting them
 function edit_tab(s::MIState, jump_spaces::Bool=false, delete_trailing::Bool=jump_spaces)
-    tab_should_complete(s) && return complete_line(s)
     set_action!(s, :edit_insert_tab)
     push_undo(s)
     edit_insert_tab(buffer(s), jump_spaces, delete_trailing) || pop_undo(s)
@@ -2559,7 +2561,7 @@ end
 const default_keymap =
 AnyDict(
     # Tab
-    '\t' => (s::MIState,o...)->edit_tab(s, true),
+    '\t' => (s::MIState,o...)->(key_should_complete(s, '\t') ? complete_line(s) : edit_tab(s, true)),
     # Shift-tab
     "\e[Z" => (s::MIState,o...)->shift_tab_completion(s),
     # Enter
@@ -2651,7 +2653,7 @@ AnyDict(
     end,
     "^Z" => (s::MIState,o...)->(return :suspend),
     # Right Arrow
-    "\e[C" => (s::MIState,o...)->edit_move_right(s),
+    "\e[C" => (s::MIState,o...)->(key_should_complete(s, nothing) ? complete_line(s) : edit_move_right(s)),
     # Left Arrow
     "\e[D" => (s::MIState,o...)->edit_move_left(s),
     # Up Arrow
@@ -2675,7 +2677,9 @@ AnyDict(
     "\el" => (s::MIState,o...)->edit_lower_case(s),
     "\ec" => (s::MIState,o...)->edit_title_case(s),
     "\ee" => (s::MIState,o...) -> edit_input(s),
-    "\em" => (s::MIState, o...) -> activate_module(s)
+    "\em" => (s::MIState, o...) -> activate_module(s),
+    # End
+    "\e[F" => (s::MIState, o...) -> (key_should_complete(s, nothing) && complete_line(s)),
 )
 
 const history_keymap = AnyDict(