rename Base.@assume_effects :total_may_throw setting to :foldable (#45534)

Author: aviatesk

base/expr.jl

@@ -402,7 +402,7 @@ julia> code_typed() do
 1 ─     return 479001600
 ) => Int64
 
-julia> Base.@assume_effects :total_may_throw @ccall jl_type_intersection(Vector{Int}::Any, Vector{<:Integer}::Any)::Any
+julia> Base.@assume_effects :foldable @ccall jl_type_intersection(Vector{Int}::Any, Vector{<:Integer}::Any)::Any
 Vector{Int64} (alias for Array{Int64, 1})
 ```
 
@@ -541,7 +541,7 @@ This `setting` combines the following other assertions:
 and is a convenient shortcut.
 
 ---
-# `:total_may_throw`
+# `:foldable`
 
 This `setting` combines the following other assertions:
 - `:consistent`
@@ -554,10 +554,10 @@ and is a convenient shortcut.
     the applied method when all the call arguments are fully known to be constant, no matter
     if the call results in an error or not.
 
-    `@assume_effects :total_may_throw` is similar to [`@pure`](@ref) with the primary
+    `@assume_effects :foldable` is similar to [`@pure`](@ref) with the primary
     distinction that the `:consistent`-cy requirement applies world-age wise rather
     than globally as described above. However, in particular, a method annotated
-    `@pure` should always be `:total` or `:total_may_throw`.
+    `@pure` should always be `:total` or `:foldable`.
     Another advantage is that effects introduced by `@assume_effects` are propagated to
     callers interprocedurally while a purity defined by `@pure` is not.
 """
@@ -580,7 +580,7 @@ macro assume_effects(args...)
             terminates_locally = true
         elseif setting === :total
             consistent = effect_free = nothrow = terminates_globally = true
-        elseif setting === :total_may_throw
+        elseif setting === :foldable
             consistent = effect_free = terminates_globally = true
         else
             throw(ArgumentError("@assume_effects $setting not supported"))

test/compiler/inference.jl

@@ -4079,7 +4079,7 @@ const CONST_DICT = let d = Dict()
     end
     d
 end
-Base.@assume_effects :total_may_throw getcharid(c) = CONST_DICT[c]
+Base.@assume_effects :foldable getcharid(c) = CONST_DICT[c]
 @noinline callf(f, args...) = f(args...)
 function entry_to_be_invalidated(c)
     return callf(getcharid, c)

test/compiler/inline.jl

@@ -1089,7 +1089,7 @@ recur_termination22(x) = x * recur_termination21(x-1)
 end
 
 const ___CONST_DICT___ = Dict{Any,Any}(Symbol(c) => i for (i, c) in enumerate('a':'z'))
-Base.@assume_effects :total_may_throw concrete_eval(
+Base.@assume_effects :foldable concrete_eval(
     f, args...; kwargs...) = f(args...; kwargs...)
 @test fully_eliminated() do
     concrete_eval(getindex, ___CONST_DICT___, :a)