More review comments

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Author: Liozou

base/file.jl

@@ -327,8 +327,6 @@ end
 # Loaded DLLs cannot be deleted on Windows, even with posix delete mode but they can be renamed.
 # delayed_delete_dll(path) does so temporarily, until later cleanup by Pkg.gc().
 function delayed_delete_dll(path)
-    drive = first(splitdrive(path))
-    tmpdrive = first(splitdrive(tempdir()))
     # in-use DLL must be kept on the same drive
     temp_path = tempname(abspath(dirname(path)); cleanup=false, suffix=string("_", basename(path)))
     @debug "Could not delete DLL most likely because it is loaded, moving to a temporary path" path temp_path
@@ -687,8 +685,37 @@ end
 # deprecated internal function used by some packages
 temp_cleanup_purge(; force=false) = force ? temp_cleanup_purge_all() : @lock TEMP_CLEANUP_LOCK temp_cleanup_purge_prelocked(false)
 
+function temp_cleanup_atexit(cleanup_dirs=keys(TEMP_CLEANUP))
+    temp_cleanup_purge_all()
+    if !isempty(cleanup_dirs)
+        rmcmd = """
+        eof(stdin)
+        for path in eachline(stdin)
+            try
+                rm(path, force=true, recursive=true)
+            catch ex
+                @warn "Failed to clean up temporary path \$(repr(path))\n\$ex" _group=:file
+            end
+        end
+        """
+        cmd = Cmd(`$(Base.julia_cmd()) --startup-file=no -e $rmcmd`; ignorestatus=true, detach=true)
+        pw = Base.PipeEndpoint()
+        rd, wr = Base.link_pipe(true, true)
+        try
+            Base.open_pipe!(pw, wr)
+        catch
+            Base.close_pipe_sync(wr)
+            rethrow()
+        end
+        run(cmd, rd, devnull, stderr; wait=false)
+        join(pw, cleanup_dirs, "\n")
+        Base.dup(wr) # intentionally leak a reference, until the process exits
+        close(pw)
+    end
+end
+
 function __postinit__()
-    Base.atexit(temp_cleanup_purge_all)
+    Base.atexit(temp_cleanup_atexit)
 end
 
 const temp_prefix = "jl_"

test/tempdepot.jl

@@ -9,22 +9,7 @@
 
 if Sys.iswindows() && !@isdefined(DEPOTS_TOREMOVE)
     const DEPOTS_TOREMOVE = String[]
-    atexit() do # launch a process that will rm the depots
-        rmcmd = """
-        for _ in 1:3600 # wait up to 1h from atexit() until the julia testing process dies
-            sleep(1)
-            ccall(:uv_kill, Cint, (Cuint, Cint), $(getpid()), 0) == Base.UV_ESRCH && break
-        end
-        for path in $DEPOTS_TOREMOVE
-            try
-                rm(path, force=true, recursive=true)
-            catch
-            end
-        end
-        """
-        cmd = Cmd(`$(Base.julia_cmd()) --startup-file=no -e $rmcmd`; ignorestatus=true, detach=true)
-        run(cmd; wait=false)
-    end
+    atexit(() -> Base.Filesystem.temp_cleanup_atexit(DEPOTS_TOREMOVE))
 end
 
 function rmdepot(depot)