Skip to content

Commit

Permalink
fix typo in cholmod.jl
Browse files Browse the repository at this point in the history
  • Loading branch information
@JeffBezanson
JeffBezanson committed Oct 11, 2014
1 parent da926d5 commit 1a4c02f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/linalg/cholmod.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ type c_CholmodTriplet{Tv<:CHMVTypes,Ti<:CHMITypes}
j::Ptr{Ti}
x::Ptr{Tv}
z::Ptr{Void}
stype:Cint
stype::Cint
itype::Cint
xtype::Cint
dtype::Cint
Expand Down

6 comments on commit 1a4c02f

@JeffBezanson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JuliaBackports

@staticfloat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported in 602f55a

@staticfloat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work?

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign of missing test coverage?

@ViralBShah
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange how this never got caught!

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed a memory leak in the cholmod stuff a while back, don't remember whether I reported it though (or if I'd be able to find the repro code any more). Might not be related.

Please sign in to comment.