Skip to content

Commit 0dbd3f7

Browse files
Move compile timing to inside @time's main timing block. Fixes >100% compilation time reports (#41286)
* ensure `@time`'s inner timing functions are compiled
1 parent 9044222 commit 0dbd3f7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

base/timing.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,11 @@ macro time(ex)
205205
quote
206206
while false; end # compiler heuristic: compile this block (alter this if the heuristic changes)
207207
local stats = gc_num()
208-
local compile_elapsedtime = cumulative_compile_time_ns_before()
209208
local elapsedtime = time_ns()
209+
local compile_elapsedtime = cumulative_compile_time_ns_before()
210210
local val = $(esc(ex))
211-
elapsedtime = time_ns() - elapsedtime
212211
compile_elapsedtime = cumulative_compile_time_ns_after() - compile_elapsedtime
212+
elapsedtime = time_ns() - elapsedtime
213213
local diff = GC_Diff(gc_num(), stats)
214214
time_print(elapsedtime, diff.allocd, diff.total_time, gc_alloc_count(diff), compile_elapsedtime, true)
215215
val
@@ -251,11 +251,11 @@ macro timev(ex)
251251
quote
252252
while false; end # compiler heuristic: compile this block (alter this if the heuristic changes)
253253
local stats = gc_num()
254-
local compile_elapsedtime = cumulative_compile_time_ns_before()
255254
local elapsedtime = time_ns()
255+
local compile_elapsedtime = cumulative_compile_time_ns_before()
256256
local val = $(esc(ex))
257-
elapsedtime = time_ns() - elapsedtime
258257
compile_elapsedtime = cumulative_compile_time_ns_after() - compile_elapsedtime
258+
elapsedtime = time_ns() - elapsedtime
259259
local diff = GC_Diff(gc_num(), stats)
260260
timev_print(elapsedtime, diff, compile_elapsedtime)
261261
val

0 commit comments

Comments
 (0)