Skip to content

[release-1.3] Backports for 1.3.0 #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredrikekre merged 15 commits into from
Sep 23, 2019
Merged

[release-1.3] Backports for 1.3.0 #1361

fredrikekre merged 15 commits into from
Sep 23, 2019

Conversation

@fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Sep 9, 2019

No description provided.

@staticfloat @fredrikekre
Properly Plumb Platform kwarg for ensure_artifact_installed()
3364084 
Otherwise, it ignores your selection of `platform` when testing to see if the artifact even exists.

(cherry picked from commit 2472c31, PR #1353)
@staticfloat @fredrikekre
Fix compress_versions() confusion with build number VersionNumber's
58634b9 
This is not a permanent fix, it's to paper over the fact that we have
two, slightly incompatible concepts of a `VersionNumber` within `Pkg`;
the `VersionNumber` and the `VersionBound`.  The latter does not support
`build` or `prerelease` specifiers, which causes much confusion within
`compress_versions()` when it attempts to compare equality of
`VersionNumber` objects with their supposedly-equivalent `VersionBound`
objects.  To fix this, we explcitly strip those pieces of information
before doing any comparisons.

(cherry picked from commit dd4fc94, PR #1350)
@fredrikekre
Copy link
Member Author

fredrikekre commented Sep 9, 2019

bors try

bors bot added a commit that referenced this pull request Sep 9, 2019
@bors
Try #1361:
eefedfd
KristofferC
KristofferC reviewed Sep 9, 2019
View reviewed changes
@bors
Copy link
Contributor

bors bot commented Sep 9, 2019

try

Build succeeded

fredrikekre and others added 3 commits September 16, 2019 10:10
@fredrikekre fredrikekre added the release Release management and versioning. label Sep 16, 2019
fredrikekre and others added 4 commits September 16, 2019 19:20
@fredrikekre
Add EditURL to basedocs.md,
afddac9 
fixes JuliaLang/julia#33237.

(cherry picked from commit 7a1b669, PR #1392)
@ChrisRackauckas @fredrikekre
Describe pre-1.0 behavior in the compat section.
d9e480e 
(cherry picked from commit be27d53, PR #1379)
@fredrikekre
Look in builddir for deps/Project.toml instead of testdir.
f06c4d0 
(cherry picked from commit 252f63d, PR #1393)
@fredrikekre
Make files read only when installing a given
114ebff 
git revision, and when installing a package because
of a dependency from a Pkg.develop'd package,
fixes #729, fixes #1313, fixes #1382.

(cherry picked from commit 2ed8e73, PR #1394)
@fredrikekre
Copy link
Member Author

fredrikekre commented Sep 17, 2019

bors try

bors bot added a commit that referenced this pull request Sep 17, 2019
@bors
Try #1361:
9e80762
@bors
Copy link
Contributor

bors bot commented Sep 17, 2019

try

Build succeeded

@KristofferC KristofferC mentioned this pull request Sep 20, 2019
Merged
18 tasks
staticfloat and others added 3 commits September 20, 2019 15:16
@staticfloat @fredrikekre
Enable Travis and Appveyor (#1400)
b464c68 
(cherry picked from commit 266c327, PR #1400)
@staticfloat @fredrikekre
Fix instantiate not installing artifacts (#1374)
94aafe2 
Also fix verbosity in many levels of downloading API
(cherry picked from commit 45be6f6, PR #1374)
@fredrikekre
Run CI for release-* branches, remove staging. (#1406)
1a6d457 
(cherry picked from commit abe0123, PR #1406)
@codecov
Copy link

codecov bot commented Sep 20, 2019 •
edited
Loading

Codecov Report

Merging #1361 into release-1.3 will increase coverage by 0.31%.
The diff coverage is 90.56%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #1361      +/-   ##
===============================================
+ Coverage        86.25%   86.56%   +0.31%     
===============================================
  Files               29       29              
  Lines             5537     5569      +32     
===============================================
+ Hits              4776     4821      +45     
+ Misses             761      748      -13
Impacted Files Coverage Δ
src/Types.jl 80.84% <100%> (+0.03%) ⬆️
src/API.jl 96.17% <100%> (+0.01%) ⬆️
src/versions.jl 93.26% <100%> (+8.24%) ⬆️
src/PlatformEngines.jl 76.19% <50%> (-0.63%) ⬇️
src/Artifacts.jl 91.6% <93.33%> (-0.04%) ⬇️
src/Operations.jl 92.54% <96.15%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c978c0...a478f1b. Read the comment docs.

@fredrikekre fredrikekre changed the title [WIP] [release-1.3] Backports for 1.3.0 [release-1.3] Backports for 1.3.0 Sep 23, 2019
@fredrikekre fredrikekre merged commit 7fc471e into release-1.3 Sep 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the backports-release-1.3 branch September 23, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees

No one assigned

Labels

release Release management and versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fredrikekre @KristofferC @00vareladavid @staticfloat @ChrisRackauckas @DilumAluthge