-
-
Notifications
You must be signed in to change notification settings - Fork 197
Pass CPU targets as cmdline args #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 82.98% 82.59% -0.39%
==========================================
Files 3 3
Lines 670 655 -15
==========================================
- Hits 556 541 -15
Misses 114 114
|
filter = false: Error During Test at D:\a\PackageCompiler.jl\PackageCompiler.jl\test\runtests.jl:80
Got exception outside of a @test
Unable to automatically download/install artifact 'fooifier' from sources listed in 'C:\Users\runneradmin\AppData\Local\Temp\jl_kTjrxv\MyApp\Artifacts.toml'.
Sources attempted:
- https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
Error: RequestError: HTTP/1.1 404 Not Found while requesting https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
- https://github.com/staticfloat/small_bin/raw/master/libfoo/libfoo.x86_64-w64-mingw32.tar.gz
Error: Tree Hash Mismatch!
Expected git-tree-sha1: d61f806c76b57e54f343634c5219d00d4c81b077
Calculated git-tree-sha1: 1[351](https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:354)b831192db9091d97e9b4bc84231ade05d210 Footnotes |
Is there an upstream issue regarding this? |
The CI error seems relevant or?
|
|
- Sysimages built with CPU targets as env var, tend to ignore them and result segfaults, when relocated to the target machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JULIA_CPU_TARGET
#790(See1) (On Julia#master and Julia#backports-release-1.9)
Footnotes
https://github.com/JuliaLang/julia/pull/48809#issuecomment-1505546852 ↩
https://buildkite.com/organizations/julialang/pipelines/julia-release-1-dot-9/builds/175/jobs/01878fbd-b60d-4609-90a7-af65eb2e8bcb/artifacts/0187900b-8624-4214-9fae-c1b8247fc16d ↩
https://github.com/JuliaLang/julia/commit/00334655d2c46da4693d41a0d69fa9a089a71df4 ↩