Skip Aqua tests when running make test-Distributed locally
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+6
to
12
| # On GitHub Actions CI (on the Distributed.jl repo): yes we run Aqua. | ||
| # On Base Julia Buildkite CI (on the JuliaLang/julia repo): no Aqua | ||
| # When the user manually runs `make test-Distributed` locally: no Aqua | ||
| if Base.get_bool_env("GITHUB_ACTIONS", false) | ||
| @testset "Aqua.jl tests" begin | ||
| include("aqua.jl") | ||
| end |
There was a problem hiding this comment.
This means pkg> test Distributed won't run Aqua tests.
I think I'd rather gate it on whether Aqua can be found.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 10 10
Lines 1949 1949
=======================================
Hits 1546 1546
Misses 403 403 ☔ View full report in Codecov by Sentry. |
|
Replaced by #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.