Add at-compat for new type declaration syntax and fix depwarn in tests #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another question is if we should implement something like @struct typename{T} <: basetype{T} begin
field::T
end
@mutable typename2{T} <: basetype2{T} begin
field::T
endSimilar to (but uglier than) the soon to be removed |
tkelman
reviewed
Feb 10, 2017
README.md
Outdated
| @@ -71,6 +71,10 @@ Currently, the `@compat` macro supports the following syntaxes: | |||
| * `@compat Array{<:Real}` and similar uses of `<:T` to define a set of parameterized types ([#20414]). | |||
| In 0.4 and 0.5, this only works for non-nested usages (e.g. you can't define `Array{<:Array{<:Real}}`). | |||
|
|
|||
| * `@compat abstract type T end` and `@compat primitive type T 8 end` | |||
| to declare abstract and primitive types. This only work when | |||
There was a problem hiding this comment.
only works when
xref the base PR
tkelman
reviewed
Feb 10, 2017
| @@ -1353,8 +1353,10 @@ end | |||
| end | |||
| @test do_boundscheck() == true | |||
|
|
|||
| @test Compat.promote_eltype_op(@functorize(+), ones(2,2), 1) === Float64 | |||
| @test Compat.promote_eltype_op(@functorize(*), ones(Int, 2), zeros(Int16,2)) === Int | |||
| if VERSION < v"0.6.0-dev.1886" | |||
There was a problem hiding this comment.
promote_eltype_op was deprecated?
There was a problem hiding this comment.
would be worth a comment to that effect
yuyichao
force-pushed
the
yyc/type
branch
2 times, most recently
from
e2a302b
to
816a7aa
Compare
This was referenced Feb 11, 2017
This was referenced Feb 11, 2017
|
The 14 packages I've tested works well with this, with only |
martinholters
added a commit
that referenced
this pull request
Aug 27, 2018
Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6.
martinholters
added a commit
that referenced
this pull request
Aug 31, 2018
* Remove at-compat for type aliases Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Nullable construction Was added in #287, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Foo{<:Bar} sugar Was added in #317 (and #336), now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for index styles Was added in #329, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for type declarations Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove unused at-compat helper functions * Remove README entries for removed at-compat functionality * new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372) * Remove `Compat.collect(A)` Was added in #350 and #351, now obsolete as no longer required on minimum supported Julia version 0.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.