Skip to content

Commit f886239

Browse files
committed
Drop compat code for floatmin and floatmax from #607
1 parent 0388309 commit f886239

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ Currently, the `@compat` macro supports the following syntaxes:
7575

7676
## Renaming
7777

78-
* `realmin` and `realmax` are now `floatmin` and `floatmax` ([#28302])
79-
8078
* `squeeze` is now `dropdims` ([#28303], [#26660]).
8179

8280
## New macros

src/Compat.jl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ end
8282
end
8383
end
8484

85-
# https://github.com/JuliaLang/julia/pull/28302
86-
if VERSION < v"0.7.0-beta2.169"
87-
const floatmin = realmin
88-
const floatmax = realmax
89-
export floatmin, floatmax
90-
end
91-
9285
# https://github.com/JuliaLang/julia/pull/28303
9386
if VERSION < v"0.7.0-beta2.143"
9487
export dropdims

test/old.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1264,3 +1264,8 @@ let a = rand(5,5)
12641264
@test vec(S[i,:]) == sort(vec(a[i,:]))
12651265
end
12661266
end
1267+
1268+
# 0.7.0-beta2.169
1269+
@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
1270+
@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
1271+
@test floatmin(zero(Float64)) == floatmin(Float64)

test/runtests.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ let
9898
@test_throws UndefKeywordError func5(x=2)
9999
end
100100

101-
# 0.7.0-beta2.169
102-
@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
103-
@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
104-
@test floatmin(zero(Float64)) == floatmin(Float64)
105-
106101
# 0.7.0-beta2.143
107102
if VERSION < v"0.7.0-beta2.143"
108103
let a = reshape(Vector(1:4),(2,2,1,1)), b = reshape(Vector(1:4), (2,2,1))

0 commit comments

Comments
 (0)