Skip to content

Commit b1c4da6

Browse files
committed
Drop compat code for floatmin and floatmax from #607
1 parent 8512dc9 commit b1c4da6

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,6 @@ Currently, the `@compat` macro supports the following syntaxes:
7878

7979
* `findin(a, b)` is now `findall(in(b), a)` ([#24673]).
8080

81-
* `realmin` and `realmax` are now `floatmin` and `floatmax` ([#28302])
82-
8381
* `squeeze` is now `dropdims` ([#28303], [#26660]).
8482

8583
## New macros

src/Compat.jl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ end
8282
end
8383
end
8484

85-
# https://github.com/JuliaLang/julia/pull/28302
86-
if VERSION < v"0.7.0-beta2.169"
87-
const floatmin = realmin
88-
const floatmax = realmax
89-
export floatmin, floatmax
90-
end
91-
9285
# https://github.com/JuliaLang/julia/pull/28303
9386
if VERSION < v"0.7.0-beta2.143"
9487
export dropdims

test/old.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,3 +1256,8 @@ let a = rand(5,5)
12561256
@test vec(S[i,:]) == sort(vec(a[i,:]))
12571257
end
12581258
end
1259+
1260+
# 0.7.0-beta2.169
1261+
@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
1262+
@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
1263+
@test floatmin(zero(Float64)) == floatmin(Float64)

test/runtests.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,6 @@ let
110110
@test_throws UndefKeywordError func5(x=2)
111111
end
112112

113-
# 0.7.0-beta2.169
114-
@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
115-
@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
116-
@test floatmin(zero(Float64)) == floatmin(Float64)
117-
118113
# 0.7.0-beta2.143
119114
if VERSION < v"0.7.0-beta2.143"
120115
let a = reshape(Vector(1:4),(2,2,1,1)), b = reshape(Vector(1:4), (2,2,1))

0 commit comments

Comments
 (0)