Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singleton support #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Wynand
Copy link

@Wynand Wynand commented Nov 19, 2021

Currently singletons don't work with lower, and this adds support for that

Effectively the singletons are printed as their class with "()" as a suffix to show that they're an instance of the singleton instead of the singleton type

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #331 (2258c48) into master (f93688a) will decrease coverage by 0.19%.
The diff coverage is 85.71%.

❗ Current head 2258c48 differs from pull request most recent head 00e171f. Consider uploading reports for the commit 00e171f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   99.51%   99.31%   -0.20%     
==========================================
  Files           5        5              
  Lines         410      440      +30     
==========================================
+ Hits          408      437      +29     
- Misses          2        3       +1     
Impacted Files Coverage Δ
src/Writer.jl 97.45% <85.71%> (-0.68%) ⬇️
src/Parser.jl 100.00% <0.00%> (ø)
src/specialized.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93688a...00e171f. Read the comment docs.

@Wynand
Copy link
Author

Wynand commented Nov 19, 2021

This issue may be relevant: #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant