-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move set_blosc!
methods to H5ZBlosc.jl
#1167
base: master
Are you sure you want to change the base?
Conversation
As far as I can tell, this usage of Requires was entirely unnecessary since the package it was "extending" already depends on HDF5.jl Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
069d059
to
60d7775
Compare
This is needed to pick up Documenter 1.4.0 which supports fully-qualified `@ref` links.
60d7775
to
d91501e
Compare
8f02318
to
330ee06
Compare
I need to think about the interaction with #1160. These methods were mainly there was backwards compatibility. |
For what it's worth, the methods are still there - I think this should behave pretty much as it did before, except that because we can't set retroactive |
@simonbyrne @musm any thoughts about this pull request? Does this require a version bump? |
Project.toml
Outdated
@@ -22,6 +22,7 @@ MPIExt = "MPI" | |||
|
|||
[compat] | |||
Compat = "3.1.0, 4" | |||
H5Zblosc = "≥ 0.1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be covered by the compat in H5Zblosc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - it should be bumped / tightened whenever this falls into a release, but doing the compat on the H5Zblosc side is probably right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be breaking, but I guess it could break version resolution?
There's already an HDF5 compat bound in H5Zblosc - that one just needs to be kept up-to-date.
a3f5379
to
59d6e46
Compare
That's the last one gone!
As far as I can tell, Requires was not necessary here since the package it was "extending" already depends on HDF5.jl