Support absolute uri in request_json
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 178 187 +9
=========================================
+ Hits 178 187 +9 ☔ View full report in Codecov by Sentry. |
DilumAluthge
reviewed
Nov 8, 2023
Merged
DilumAluthge
reviewed
Nov 8, 2023
|
@DilumAluthge I added tests but #127 (comment) is not resolved yet - I'm fine with your suggestion as well, I'd just like to confirm that you would still prefer it 🙂 |
DilumAluthge
requested changes
Nov 16, 2023
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
DilumAluthge
approved these changes
Nov 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs (https://www.hl7.org/fhir/R4/datatypes.html#uri), uris can be relative and absolute. For instance, the links to the current and the next page in the paginated response to http://hapi.fhir.org/baseR4/Patient?given=Jason&family=Argonaut&_count=2&_pretty=true are URLs that already contain the base URL.
However, currently
request_jsondoes not support such paths but always assumes that thepathstring is relative to the base URL. With this PR also absolute paths are supported.This PR is based on #125.