Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dialogs #14

Closed
tknopp opened this issue Dec 28, 2022 · 2 comments
Closed

Document dialogs #14

tknopp opened this issue Dec 28, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@tknopp
Copy link
Member

tknopp commented Dec 28, 2022

The dialogs are currently not documented. This is just a reminder for us to do so. We need to document the synchronous and asynchronous variants and give clear examples like the one in #13 how to call dialogs from callbacks.

In addition to the high-level methods we should also showcase how to write a custom dialog with GtkDialog.
@jwahlstrand
Copy link
Member

I have part of this done locally (along with other unfinished docs). I'll update it and commit.

@jwahlstrand jwahlstrand added the documentation Improvements or additions to documentation label May 12, 2024
@jwahlstrand
Copy link
Member

I just added a bit more to the documentation on dialogs. Regarding GtkDialog, it was deprecated in GTK 4.10 (see https://blog.gtk.org/2022/10/30/on-deprecations/) in favor of just creating a GtkWindow (as is done in input_dialog now). I added an example of that.

I'm going to close this but as always feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tknopp @jwahlstrand