[Port] fix induced_subgraph indexing with vector of Bools #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 107 107
Lines 5622 5625 +3
=======================================
+ Hits 5592 5595 +3
Misses 30 30 |
Currently both `getindex` and `induced_subgraph` handle `AbstractVector{Bool}` argument in a way inconsistent with Julia Base rules.
simonschoelly
force-pushed
the
port_1573
branch
from
4a74238
to
8bbf1c5
Compare
simonschoelly
approved these changes
Jan 9, 2022
There was a problem hiding this comment.
I am merging this now. This PR would probably create some issues with graphs that use Bool as eltype, but then such a graph does not really make sense anyway.
Another thing that could go wrong has to do with the method signature, as it is if of the form
induced_subgraph(g::AbstractGraph, vlist::AbstractVector{Bool})so I guess it could lead to some issues with some downstream packages that implement
induced_subgraph(g::SomeSpecificGraph, vlist)but I think in such a case, we could just try to figure out a better method signature later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #1573