Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding approximate algorithm for random_configuration_model #149

Open
bkamins opened this issue Jun 23, 2022 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@bkamins
Copy link
Contributor

bkamins commented Jun 23, 2022

Follow up to https://stackoverflow.com/questions/72732571/random-configuration-modeln-e-takes-to-long-on-lightgraphs-jl.

Currently random_configuration_model uses rejection sampling which is very slow for tight configurations. Probably allowing for approximate sampling with some edge rewiring strategy could be allowed (iGraph implements this).

@bkamins bkamins added the bug Something isn't working label Jun 23, 2022
@etiennedeg
Copy link
Member

I already noticed that the algorithm was not the true random_configuration_model as it does not allows the creation of multigraphs. If I remember correctly, even with the rejection sampling used, I think that the current generation is not exactly uniform (to be checked), so maybe it makes sense to do that...

@bkamins
Copy link
Contributor Author

bkamins commented Jun 24, 2022

does not allows the creation of multigraphs

I assumed it was on purpose as SimpleGraph does not support multigraphs

current generation is not exactly uniform

Ah - indeed - I have just checked. It does some "naive" collision resolution breaking uniformity. So indeed we are neither uniform nor "fast near uniform" now.

@bkamins
Copy link
Contributor Author

bkamins commented Jun 24, 2022

I am not sure why bug label was added here automatically. I would classify it as feature request.

@etiennedeg etiennedeg added enhancement New feature or request and removed bug Something isn't working labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants