Skip to content

Commit 36414d6

Browse files
committed
Merge pull request #98 from mschauer/range1
Range1 replaced for UnitRange
2 parents aac9f0a + d16553c commit 36414d6

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

examples/manipulate.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ function make_widget(parent, widget::SliderWidget)
3939
sl
4040
end
4141

42-
slider(nm::String, label::String, rng::Range1, initial::Integer) = SliderWidget(nm, label, initial, rng)
43-
slider(nm::String, label::String, rng::Range1) = slider(nm, label, rng, minimum(rng))
44-
slider(nm::String, rng::Range1) = slider(nm, nm, rng, minimum(rng))
42+
slider(nm::String, label::String, rng::UnitRange, initial::Integer) = SliderWidget(nm, label, initial, rng)
43+
slider(nm::String, label::String, rng::UnitRange) = slider(nm, label, rng, minimum(rng))
44+
slider(nm::String, rng::UnitRange) = slider(nm, nm, rng, minimum(rng))
4545

4646
type PickerWidget <: ManipulateWidget
4747
nm

src/containers.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,11 @@ function forget(parent::TTk_Container, child::Widget)
132132
end
133133

134134
## grid ...
135-
IntOrRange = Union(Integer, Range1)
135+
IntOrRange = Union(Integer, UnitRange)
136136
function grid(child::Widget, row::IntOrRange, column::IntOrRange; kwargs...)
137137
path = get_path(child)
138-
if isa(row, Range1) rowspan = 1 + maximum(row) - minimum(row) else rowspan = 1 end
139-
if isa(column, Range1) columnspan = 1 + maximum(column) - minimum(column) else columnspan = 1 end
138+
if isa(row, UnitRange) rowspan = 1 + maximum(row) - minimum(row) else rowspan = 1 end
139+
if isa(column, UnitRange) columnspan = 1 + maximum(column) - minimum(column) else columnspan = 1 end
140140

141141
row = minimum(row) - 1
142142
column = minimum(column) - 1

src/widgets.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ set_editable(widget::Tk_Combobox, value::Bool) = widget[:state] = value ? "norma
239239

240240
## Slider
241241
## deprecate this interface as integer values are not guaranteed in return.
242-
function Slider{T <: Integer}(parent::Widget, range::Range1{T}; orient="horizontal")
242+
function Slider{T <: Integer}(parent::Widget, range::UnitRange{T}; orient="horizontal")
243243
w = Slider(parent, orient=orient)
244244
var = tclvar()
245245
tclvar(var, minimum(range))
@@ -275,11 +275,11 @@ end
275275
## Spinbox
276276
type Tk_Spinbox <: TTk_Widget
277277
w::TkWidget
278-
range::Range1{Int}
278+
range::UnitRange{Int}
279279
Tk_Spinbox(w::TkWidget) = new(w, 1:1)
280280
end
281281

282-
function Spinbox{T <: Integer}(parent, range::Range1{T})
282+
function Spinbox{T <: Integer}(parent, range::UnitRange{T})
283283
w = Spinbox(parent)
284284
set_items(w, range)
285285
set_value(w, minimum(range))
@@ -290,7 +290,7 @@ get_value(widget::Tk_Spinbox) = parse(Int, tcl(widget, "get"))
290290
set_value(widget::Tk_Spinbox, value::Integer) = tcl(widget, "set", value)
291291

292292
get_items(widget::Tk_Spinbox) = widget.range
293-
function set_items{T <: Integer}(widget::Tk_Spinbox, range::Range1{T})
293+
function set_items{T <: Integer}(widget::Tk_Spinbox, range::UnitRange{T})
294294
configure(widget, from=minimum(range), to = maximum(range), increment = step(range))
295295
widget.range = range
296296
end

0 commit comments

Comments
 (0)