Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: a more general validity check for updates #95

Open
hhaensel opened this issue Jul 5, 2022 · 1 comment
Open

Feature request: a more general validity check for updates #95

hhaensel opened this issue Jul 5, 2022 · 1 comment

Comments

@hhaensel
Copy link

hhaensel commented Jul 5, 2022

I saw that version 5 introduced ignore_equal_values.

In the past I already thought it would be nice to have a general acceptance test for incoming updates.
So while version 5 is not officially released I propose to change the architecture to have a field isinvalid which accepts a function as validy check. In case of ignore_equal_values isinvalid would be set to isequal

I'll submit a draft PR how that could look like.
@hhaensel hhaensel mentioned this issue Jul 5, 2022
Draft
@hhaensel
Copy link
Author

@travigd @IanButterworth
May I ask your opinion about the above proposal? I think that this could be introduced in a non-breaking way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hhaensel