Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4.0] why not keep connect! same as 0.3.x, change the docs and make a new func? #70

Closed
touchft opened this issue Feb 24, 2021 · 2 comments

Comments

@touchft
Copy link

touchft commented Feb 24, 2021

how about make a new function and keep connect! as 0.3.x?
[0.3.x] connect!(x,y) means x->y
[0.4.x] plugin!(x,y)/update!(x,y)/transfer!(x,y) means y->x

@timholy
Copy link
Member

timholy commented Feb 24, 2021

  1. Because the old function did the opposite of what it said in the in documentation.
  2. The Julia convention is that the modified argument is first. This case is actually ambiguous because while in connect!(x, y), x will be lazily-modified whenever y is, the way Observables is implemented means the actual change in connectivity is made to y. So this argument isn't as definitive as it could be.
  3. If people had wanted to preserve the old behavior, they should have submitted a PR to fix the docstring. No one did over years of use.
  4. We don't need 2 functions that do the same thing

@touchft
Copy link
Author

touchft commented Feb 25, 2021

Thank you!

@touchft touchft closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants