Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to solve design issues with Observables2 #47

Closed
jkrumbiegel opened this issue Jul 28, 2020 · 3 comments
Closed

Trying to solve design issues with Observables2 #47

jkrumbiegel opened this issue Jul 28, 2020 · 3 comments

Comments

@jkrumbiegel
Copy link
Contributor

I'd like some input on my redesign idea https://github.com/jkrumbiegel/Observables2.jl

I've noticed that in Makie, it gets quite problematic that observables don't tell you who they are listening to. That means you can't disconnect easily and that means often resources are never garbage collected until the whole Scene is destroyed.

I've written my reasoning down in the README and it would be great if those who are interested take a look.

@timholy
Copy link
Member

timholy commented Jan 2, 2021

I'm a bit confused, because the README says

every time you create an observable using on

But on doesn't (now) create an Observable. Perhaps it did when you wrote this? map does, is that the problem you're actually concerned about?

As far as the disconnect problem goes, I think we could solve it by having an optional obsfuncs field in an Observable and having map! store the output of onany there.

@timholy
Copy link
Member

timholy commented Jan 2, 2021

Ah, it looks like #48 solved many of the issues this was proposed to cover (and was submitted after the OP here). Perhaps close? Or leave open to address #48 (comment)?

@jkrumbiegel
Copy link
Contributor Author

sorry yeah this has become obsolete :) I'll close it, there wasn't that much room for a redesign after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants