switch to StaticArrays and get 0.6 working [WIP] #80
Conversation
|
This disables convexhulls and gjk for now, since they error and I don't really use that part of GeometryTypes. |
|
Also, seems like relying on StaticArrays makes GeometryTypes 0.6 only -.- ... not sure if I like that, but maybe reasonable, considering that people can tag a previous version for 0.5! |
|
I will fix the gjk stuff, when I switch to v0.6. |
|
Should I fork this branch or better wait until its merged with master? |
|
hm good question! I'm a bit hesitant with merging it, since it makes geometrytypes 0.6 only... But maybe it's time for that! Note that you'll need: JuliaArrays/StaticArrays.jl#138 |
|
No rush from my side. |
Yes. It's time! :) (I really miss being able to plot stuff in 0.6.) |
| for (i,j) in enumerate(range) | ||
| result[i] = vec[mod1(j, length(vec))] | ||
| end | ||
| result[end] = endpoint | ||
| result | ||
| end | ||
|
|
||
|
|
||
| # Taken from Iterators.jl, since it's not possible to use Iterators.jl on 0.6 with precompilation |
There was a problem hiding this comment.
when you copy code, you need to respect the license of that code
There was a problem hiding this comment.
oh, that was just supposed to be a local stop gap solution. Is there actually a fix by now? I just tried it right now and am still getting a precompile error on first precompile when importing Iterators....
There was a problem hiding this comment.
ha can't reproduce it anymore :) I removed the code in #100
No description provided.