Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piecewise Polynomial Kernel #177

Closed
willtebbutt opened this issue Sep 25, 2020 · 1 comment · Fixed by #225
Closed

Piecewise Polynomial Kernel #177

willtebbutt opened this issue Sep 25, 2020 · 1 comment · Fixed by #225

Comments

@willtebbutt
Copy link
Member

willtebbutt commented Sep 25, 2020

The PiecewisePolynomialKernel is something of an oddity in that our current implementation accepts an argument that parametrises a distance. While the dimensionality of this argument is needed so that we can ensure positive definiteness, the warping of the input space that it performs can be achieved via transform.

It would be great if someone could refactor this kernel for our next minor release (we might want to think about getting into the habit of maintaining a dev branch or something)

@devmotion
Copy link
Member

It seems, similarly maybe the Mahalanobis kernel could be removed completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants