-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting ColVecs, RowVecs and vec_of_vecs #163
Comments
Absolutely. We've also not properly documented their use. A PR that both exports them and makes documentation on the matter visible to users would be great. |
Hey I would like to take up this issue . |
Hi @codeboy5 , thanks for contributing! |
Should also address this comment: #213 (comment) |
Should also add a docstring for |
As I wrote in the comment, I disagree. In my opinion there is no need for a docstring since it is an internal detail that is irrelevant for users. It is only relevant that by default columns are observations. |
Solved in #159 |
Shouldn't ColVecs, RowVecs and vec_of_vecs be available to the users? If we are to promote the use of these abstractions, I think it is prudent we export them.
The text was updated successfully, but these errors were encountered: