-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move backend
to GPUArraysCore.jl
#420
Conversation
I'm not sure about this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd just change the export/import, but this is good to go otherwise.
@maleadt I'm assuming we don't want to export |
This reverts commit 0137d18.
Oh, no, we don't want that indeed, good catch. |
Why did you change the JLArrays compat here? Adding a |
Oh yes. I must misread the |
Second take of JuliaGPU/Adapt.jl#50.
This PR wants to move
backend
toGPUArraysCore.jl
, which would help us to implement broadcast forStructArray
on gpu. (see JuliaArrays/StructArrays.jl#215)I hope it's also useful for other arraywrappers.
(I only bump
GPUArraysCore
's version as we haven't registered a newGPUArrays
.)