Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for qr of strided inputs (non-contiguous views) #1764

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

evelyne-ringoot
Copy link
Contributor

Adding view support for CUDA.jl QR and tests

lib/cusolver/linalg.jl Outdated Show resolved Hide resolved
vchuravy and others added 2 commits February 9, 2023 17:43
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
@maleadt
Copy link
Member

maleadt commented Feb 10, 2023

Looks like some more functions will need their signatures widened (as CI shows fallback functionality being hit).

@maleadt maleadt added enhancement New feature or request cuda libraries Stuff about CUDA library wrappers. labels Feb 10, 2023
@maleadt maleadt changed the title Qr views Support for qr of strided inputs (non-contiguous views) Feb 10, 2023
@vchuravy
Copy link
Member

vchuravy commented Feb 10, 2023

@maleadt
Copy link
Member

maleadt commented Feb 10, 2023

No reason those shouldn't be an AnyGPUArray.

@evelyne-ringoot
Copy link
Contributor Author

Changed this in JuliaGPU/GPUArrays.jl#452

@maleadt
Copy link
Member

maleadt commented Feb 15, 2023

I've tagged GPUArrays 8.6.3 with this fix.

@evelyne-ringoot
Copy link
Contributor Author

Linking JuliaLang/julia#48780 for the dimension issues in the tests

@evelyne-ringoot evelyne-ringoot marked this pull request as draft March 2, 2023 22:28
@evelyne-ringoot evelyne-ringoot marked this pull request as ready for review March 2, 2023 23:56
@jpsamaroo jpsamaroo requested a review from maleadt March 3, 2023 14:55
@evelyne-ringoot evelyne-ringoot marked this pull request as draft March 7, 2023 04:59
@evelyne-ringoot
Copy link
Contributor Author

Pending support for in-place qr of views
Linking JuliaGPU/GPUArrays.jl#458 for necessary changes in LinearAlgebra

@evelyne-ringoot evelyne-ringoot marked this pull request as ready for review March 10, 2023 04:16
@evelyne-ringoot evelyne-ringoot marked this pull request as draft March 10, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants