Revamp section describing how to fix 1:nthreads() pattern
#137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonProtter
changed the title
1:nthreads() pattern1:nthreads() pattern
MasonProtter
changed the title
1:nthreads() pattern1:nthreads() pattern
Member
Author
|
cc @KristofferC. If we go with these changes, you can add a link to this doc section in your bullet point about |
|
👍 |
|
What do you think about adding a section with |
Member
Author
|
Yeah definitely. Once v1.12 is out, that should probably be the preferred solution we advertise. Before 1.12 is out, I'd be fine including sections on them, but I'm not sure the best place to put it, since it's not really actionable or helpful for the vast majority of users yet. |
|
FYI, I have opened issues on the relevant repos now. |
Member
Author
|
Okay, here's a link to those fixed docs if you need it: https://juliafolds2.github.io/OhMyThreads.jl/dev/literate/tls/tls/#The-naive-(and-incorrect)-approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
This PR fixes the section describing
1:nthreads()anti-pattern, and adds a note that it will error in v1.12 by default, not just if someone purposefully starts julia with an interactive thread. The fix described now usesmaxthreadid(), and has more info on why we don't think it's a good idea.@carstenbauer if you approve of these changes, can you run the docs build pipeline on your machine again so it doesn't change a bunch from being run on my machine?