Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaDiff/Diffractor.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d0b3e3e
Choose a base ref
...
head repository: JuliaDiff/Diffractor.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a8224dd
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on May 1, 2024

  1. stage1: Mark partial and primal helpers as @inline 

    It's unclear whether this is a compiler bug upstream, but I've observed
invokes like this in the wild:
```
%xxx = invoke DAECompiler.partial(%135::Diffractor.TangentBundle{1}, 1::Int64)::Any
```

which are (clearly) very poorly typed. `%135` was a fully concrete type,
so I'm not sure why the tangent type parameters ended up getting
stripped off.

In any case, the implementations here are so small that they are
probably best just inlined anyway.
    @topolarity
    topolarity committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b883867 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge pull request #291 from topolarity/ct/inline-partial-primal 

    stage1: Mark `partial` and `primal` helpers as `@inline`
    @oxinabox
    oxinabox authored May 3, 2024
    Configuration menu
    Copy the full SHA
    9fcbd0c View commit details
    Browse the repository at this point in the history

  2. Update Project.toml

    @oxinabox
    oxinabox authored May 3, 2024
    2 Configuration menu
    Copy the full SHA
    a8224dd View commit details
    Browse the repository at this point in the history
Loading