Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type promotion rules for NoTangent and ZeroTangent, and add eltype for NoTangent #682

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add type promotion rules for NoTangent and ZeroTangent, and add eltype for NoTangent #682

merged 3 commits into from
Sep 17, 2024

Conversation

BioTurboNick
Copy link
Contributor

@BioTurboNick
Copy link
Contributor Author

Seems the only failing tests are unrelated.

simeonschaub
simeonschaub approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to bump the version too so we can tag this right away?

@BioTurboNick
Copy link
Contributor Author

done

@simeonschaub simeonschaub merged commit 2f2c941 into JuliaDiff:main Sep 17, 2024
22 of 25 checks passed
@simeonschaub simeonschaub mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioTurboNick @simeonschaub