fix linear indexing of splitdimsview (#40)

Author: aplavin

src/splitdims.jl

@@ -73,6 +73,7 @@ end
 end
 
 @generated function slice_inds(i::CartesianIndex, ::Val{dims}, ::Val{n}) where {dims, n}
+    @assert length(i) == length(dims)
     out = []
     for j in 1:n
         k = findfirst(==(j), dims)
@@ -96,7 +97,7 @@ Base.parent(a::SplitDimsArray) = a.parent
 axes(a::SplitDimsArray{T, N, Dims}) where {T, N, Dims} = getindices(axes(parent(a)), Dims)
 size(a::SplitDimsArray{T, N, Dims}) where {T, N, Dims} = getindices(size(parent(a)), Dims)
 Base.IndexStyle(::SplitDimsArray) = Base.IndexCartesian()
-@propagate_inbounds function Base.getindex(a::SplitDimsArray{T, N, Dims}, i::Int...) where {T, N, Dims}
+@propagate_inbounds function Base.getindex(a::SplitDimsArray{T, N, Dims}, i::Vararg{Int, N}) where {T, N, Dims}
     return view(parent(a), slice_inds(CartesianIndex(i), Val(Dims), Val(ndims(parent(a))))...)
 end
 

test/splitdims.jl

@@ -34,12 +34,21 @@ end
     @test splitdimsview([1 2; 3 4], (1, 2)) == tmp
     tmp[1,2][] = 3; tmp[2,1][] = 2
     @test splitdimsview([1 2; 3 4], (2, 1)) == tmp
+    # indexing
+    @test splitdimsview([1 2; 3 4], (1, 2))[2, 1] == fill(3)
+    @test splitdimsview([1 2; 3 4], (1, 2))[2] == fill(3)
+    @test splitdimsview([1 2; 3 4], (1, 2))[CartesianIndex(2)] == fill(3)
 
     # Vector
     @test splitdimsview([1,2,3]) == [fill(1, ()), fill(2, ()), fill(3, ())]
     @test splitdimsview([1,2,3], (1,)) == [fill(1, ()), fill(2, ()), fill(3, ())]
     @test splitdimsview([1,2,3], ()) == fill([1,2,3], ())
+    # indexing
+    @test splitdimsview([1,2,3], (1,))[2] == fill(2)
+    @test splitdimsview([1,2,3], (1,))[CartesianIndex(2)] == fill(2)
 
     # Array{0}
     @test splitdimsview(fill(1, ())) == fill(fill(1, ()), ())
+    # indexing
+    @test splitdimsview(fill(1, ()))[] == fill(1)
 end