You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fourth hits the same method as 2/3, but passes in Parsers.Options(; quoted=true) to set that explicitly ...but returns a different answer to 1 (xparse(String, str; quoted=true)), because Options() defaults to delim=nothing whereas 1 sets delim=UInt8(',')
This is now very off-topic from your original issue (sorry), so can move it to a new issue, but i think perhaps we could simplify the xparse interface to make this whole thing a little less confusing / more explicit.
I think i'd be in favour of requiring a user-given ::Options argument.
I think we have too many different
xparse
methods that set different defaults.The first hits this, which passes
quoted::Bool=true
:Parsers.jl/src/Parsers.jl
Lines 211 to 212 in e2259a6
The second hits this, which uses
Parsers.XOPTIONS
Parsers.jl/src/Parsers.jl
Lines 217 to 218 in e2259a6
XOPTIONS
hasquoted=true
Parsers.jl/src/Parsers.jl
Line 164 in e2259a6
XOPTIONS
exist?)The third hits the same method as 2, but passing in
Parsers.Options()
which hasquoted=false
:Parsers.jl/src/Parsers.jl
Line 157 in e2259a6
The fourth hits the same method as 2/3, but passes in
Parsers.Options(; quoted=true)
to set that explicitly ...but returns a different answer to 1 (xparse(String, str; quoted=true)
), becauseOptions()
defaults todelim=nothing
whereas 1 setsdelim=UInt8(',')
Parsers.jl/src/Parsers.jl
Line 149 in e2259a6
This is now very off-topic from your original issue (sorry), so can move it to a new issue, but i think perhaps we could simplify the
xparse
interface to make this whole thing a little less confusing / more explicit.I think i'd be in favour of requiring a user-given
::Options
argument.cc @quinnj
Originally posted by @nickrobinson251 in #119 (comment)
The text was updated successfully, but these errors were encountered: