Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add suffix to select/transform/combine #2397

Merged
merged 7 commits into from
Sep 5, 2020
Merged

add suffix to select/transform/combine #2397

merged 7 commits into from
Sep 5, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 30, 2020

Fixes #2396

I ended up deciding that suffix should be Bool (other uses did not make sense for me).

Before I update the docs and write tests a comment if we all agree that suffix kwarg name is OK (I am rather convinced) + that it is enough to make it Bool (here I am pretty convinced).

@bkamins bkamins added feature non-breaking The proposed change is not breaking labels Aug 30, 2020
@bkamins bkamins added this to the 1.0 milestone Aug 30, 2020
@bkamins
Copy link
Member Author

bkamins commented Aug 30, 2020

OK - I have added tests, updated docstrings, and started throwing an error when empty column selector is passed.

nalimilan
nalimilan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small suggestions.

src/abstractdataframe/selection.jl Outdated Show resolved Hide resolved
src/groupeddataframe/splitapplycombine.jl Outdated Show resolved Hide resolved
@bkamins @nalimilan
Apply suggestions from code review
4a1cd4c 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins mentioned this pull request Aug 31, 2020
Merged
@bkamins
Copy link
Member Author

bkamins commented Sep 5, 2020

I have added renamecols in the categorical deprecation

@bkamins bkamins merged commit 38027c7 into JuliaData:master Sep 5, 2020
@bkamins bkamins deleted the add_suffix branch September 5, 2020 08:55
@bkamins
Copy link
Member Author

bkamins commented Sep 5, 2020

Thank you!

@pdeffebach
Copy link
Contributor

We should add a news.md entry for this!

@bkamins
Copy link
Member Author

bkamins commented Sep 17, 2020

We have, it is just called renamecols (the same for joins) - for consistency across different functions.

@pdeffebach
Copy link
Contributor

Ah thanks!

@JuliaRegistrator JuliaRegistrator mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
feature non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

add a kwarg to reuse the input column names in cols => fun in select/transform/combine
3 participants
@bkamins @pdeffebach @nalimilan